New functions CLng and CDbl#25
Merged
verhas merged 2 commits intoverhas:masterfrom Feb 4, 2020
Merged
Conversation
verhas
requested changes
Feb 4, 2020
Owner
verhas
left a comment
verhas
left a comment
There was a problem hiding this comment.
Great code. The only issue is the message in the exceptions. Please use undef instead of NULL in the message. NULL is confusing for the BASIC developers.
| @BasicFunction(classification = Utility.class) | ||
| static public Long clng(final Object arg) throws BasicRuntimeException { | ||
| if (arg == null) { | ||
| throw new BasicRuntimeException("NULL cannot be converted to long"); |
Owner
There was a problem hiding this comment.
See my reasoning about NULL above and fix this message also. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New functions CLng and CDbl.